284313f908
Some checks are pending
Bidi Control Character Guard / bidi-control-guard (push) Waiting to run
Circular Dependency Check / Check for new circular dependencies (push) Waiting to run
Citus Migration Smoke / Combined migrations on single-node Citus (push) Waiting to run
E2E Fresh Install Tests / fresh-install-e2e (push) Waiting to run
ext-v2 guardrails / Run ext-v2 guard and ESLint (push) Waiting to run
Integration Tests / Check for relevant changes (push) Waiting to run
Integration Tests / ${{ (github.event_name == 'schedule' || github.event.inputs.suite == 'full') && 'Full integration suite' || 'Tier-1 integration subset' }} (push) Blocked by required conditions
Mobile checks / Mobile lint + typecheck (push) Waiting to run
Mobile checks / Mobile unit tests (push) Waiting to run
Mobile checks / Mobile dependency audit (report) (push) Waiting to run
Mobile checks / Mobile reproducibility checks (push) Waiting to run
Secrets guard (env backups) / Ensure no tracked env backup files (push) Waiting to run
Temporal Readiness / fast-readiness (push) Waiting to run
Temporal Readiness / docker-parity (push) Waiting to run
TypeScript Type Check / Nx affected typecheck (push) Waiting to run
Unit Tests / Skipped-test budget (push) Waiting to run
Unit Tests / Nx affected unit tests (push) Waiting to run
Unit Tests / Server unit coverage (informational) (push) Waiting to run
Validate Tenant Management Schema / Check for relevant changes (push) Waiting to run
Validate Tenant Management Schema / Validate Tenant Management Schema (push) Blocked by required conditions
EE Workflows Build Guard / ee-workflows-build-guard (push) Waiting to run
Excluded: .git, node_modules, secrets/, compose.env, assemblyscript tgz Source: /opt/alga-psa on psa.joliet.tech
48 lines
1.8 KiB
Markdown
48 lines
1.8 KiB
Markdown
# Time Entries E2E Test Status
|
|
|
|
## Summary
|
|
- **Total Tests**: 39
|
|
- **Passing**: 31
|
|
- **Failing**: 8
|
|
|
|
## Fixed Issues
|
|
|
|
### Permission Tests (4/4 passing)
|
|
The permission tests were failing because they were creating API keys for users that already had all permissions. Fixed by creating new users without any roles/permissions before creating the API keys.
|
|
|
|
Fixed tests:
|
|
- ✅ should enforce read permissions for listing
|
|
- ✅ should enforce create permissions
|
|
- ✅ should enforce update permissions
|
|
- ✅ should enforce delete permissions
|
|
|
|
## Remaining Failures
|
|
|
|
### 1. List filtering tests (3 failures)
|
|
- **should filter by date range**: Expected 2 entries but got 3
|
|
- **should filter by user**: Expected 1 entry but got 2
|
|
- **should filter by billable status**: Some entries not matching the billable filter
|
|
|
|
These appear to be test data isolation issues where entries from other tests are interfering.
|
|
|
|
### 2. Approval tests (2 failures)
|
|
- **should approve time entries**: Getting 403 Forbidden - missing 'approve' permission
|
|
- **should reject invalid entry IDs for approval**: Getting 403 instead of 400
|
|
|
|
The test user doesn't have the 'approve' permission (only CRUD permissions are set up).
|
|
|
|
### 3. Export test (1 failure)
|
|
- **should export time entries to CSV**: Headers not being set correctly
|
|
|
|
### 4. Templates test (1 failure)
|
|
- **should list time entry templates**: Database table "time_entry_templates" doesn't exist
|
|
|
|
### 5. Error handling test (1 failure)
|
|
- **should handle invalid date format**: Expected 400 but got 200 (validation not working for date format)
|
|
|
|
## Next Steps
|
|
1. Add 'approve' permission to the test setup
|
|
2. Create the missing time_entry_templates table
|
|
3. Fix date validation in the API
|
|
4. Improve test data isolation for filtering tests
|
|
5. Fix CSV export headers |