284313f908
Some checks are pending
Bidi Control Character Guard / bidi-control-guard (push) Waiting to run
Circular Dependency Check / Check for new circular dependencies (push) Waiting to run
Citus Migration Smoke / Combined migrations on single-node Citus (push) Waiting to run
E2E Fresh Install Tests / fresh-install-e2e (push) Waiting to run
ext-v2 guardrails / Run ext-v2 guard and ESLint (push) Waiting to run
Integration Tests / Check for relevant changes (push) Waiting to run
Integration Tests / ${{ (github.event_name == 'schedule' || github.event.inputs.suite == 'full') && 'Full integration suite' || 'Tier-1 integration subset' }} (push) Blocked by required conditions
Mobile checks / Mobile lint + typecheck (push) Waiting to run
Mobile checks / Mobile unit tests (push) Waiting to run
Mobile checks / Mobile dependency audit (report) (push) Waiting to run
Mobile checks / Mobile reproducibility checks (push) Waiting to run
Secrets guard (env backups) / Ensure no tracked env backup files (push) Waiting to run
Temporal Readiness / fast-readiness (push) Waiting to run
Temporal Readiness / docker-parity (push) Waiting to run
TypeScript Type Check / Nx affected typecheck (push) Waiting to run
Unit Tests / Skipped-test budget (push) Waiting to run
Unit Tests / Nx affected unit tests (push) Waiting to run
Unit Tests / Server unit coverage (informational) (push) Waiting to run
Validate Tenant Management Schema / Check for relevant changes (push) Waiting to run
Validate Tenant Management Schema / Validate Tenant Management Schema (push) Blocked by required conditions
EE Workflows Build Guard / ee-workflows-build-guard (push) Waiting to run
Excluded: .git, node_modules, secrets/, compose.env, assemblyscript tgz Source: /opt/alga-psa on psa.joliet.tech
1.2 KiB
1.2 KiB
Recurring Service-Period Edit Validation
F248 defines the first neighbor-aware validation rule for future persisted service-period edits.
Continuity Rule
User edits are validated against adjacent active rows on the same scheduleKey.
The v1 rule is intentionally simple and explicit:
- the edited row must remain contiguous with the immediately previous active service period
- the edited row must remain contiguous with the immediately next active service period
- continuity is evaluated on canonical
servicePeriodbounds, not invoice headers
shared/billingClients/recurringServicePeriodEditValidation.ts now makes that executable.
Rejected States
The helper rejects four continuity failures with clear messages:
- gap before the edited period
- overlap before the edited period
- gap after the edited period
- overlap after the edited period
The boundary-adjustment and skip/defer helpers now call the same validator when sibling schedule rows are supplied.
Deliberate Boundary
This checkpoint still does not define:
- UI transport of sibling context
- cross-schedule conflict handling when source-rule regeneration collides with edited rows
- split / merge continuity semantics
Those remain sequenced behind F249-F251.