284313f908
Some checks are pending
Bidi Control Character Guard / bidi-control-guard (push) Waiting to run
Circular Dependency Check / Check for new circular dependencies (push) Waiting to run
Citus Migration Smoke / Combined migrations on single-node Citus (push) Waiting to run
E2E Fresh Install Tests / fresh-install-e2e (push) Waiting to run
ext-v2 guardrails / Run ext-v2 guard and ESLint (push) Waiting to run
Integration Tests / Check for relevant changes (push) Waiting to run
Integration Tests / ${{ (github.event_name == 'schedule' || github.event.inputs.suite == 'full') && 'Full integration suite' || 'Tier-1 integration subset' }} (push) Blocked by required conditions
Mobile checks / Mobile lint + typecheck (push) Waiting to run
Mobile checks / Mobile unit tests (push) Waiting to run
Mobile checks / Mobile dependency audit (report) (push) Waiting to run
Mobile checks / Mobile reproducibility checks (push) Waiting to run
Secrets guard (env backups) / Ensure no tracked env backup files (push) Waiting to run
Temporal Readiness / fast-readiness (push) Waiting to run
Temporal Readiness / docker-parity (push) Waiting to run
TypeScript Type Check / Nx affected typecheck (push) Waiting to run
Unit Tests / Skipped-test budget (push) Waiting to run
Unit Tests / Nx affected unit tests (push) Waiting to run
Unit Tests / Server unit coverage (informational) (push) Waiting to run
Validate Tenant Management Schema / Check for relevant changes (push) Waiting to run
Validate Tenant Management Schema / Validate Tenant Management Schema (push) Blocked by required conditions
EE Workflows Build Guard / ee-workflows-build-guard (push) Waiting to run
Excluded: .git, node_modules, secrets/, compose.env, assemblyscript tgz Source: /opt/alga-psa on psa.joliet.tech
37 lines
2.0 KiB
Markdown
37 lines
2.0 KiB
Markdown
# Scratchpad — Ticket comment order browser preference
|
|
|
|
- Plan slug: `ticket-comment-order-browser-preference`
|
|
- Created: `2026-03-09`
|
|
|
|
## What This Is
|
|
|
|
Keep a lightweight, continuously-updated log of discoveries and decisions made while implementing this plan.
|
|
|
|
Prefer short bullets. Append new entries as you learn things, and also *update earlier notes* when a decision changes or an open question is resolved.
|
|
|
|
## Decisions
|
|
|
|
- (2026-03-09) Persist ticket comment order per browser with `localStorage`, not backend `user_preferences`, because the approved scope only requires per-browser memory.
|
|
- (2026-03-09) Keep `defaultNewestFirst` as the fallback when no browser value exists so current server-provided defaults continue to work.
|
|
- (2026-03-09) Read the saved browser value in a mount-time `useEffect` instead of the initial state initializer to avoid server/client hydration mismatch risk.
|
|
|
|
## Discoveries / Constraints
|
|
|
|
- (2026-03-09) `TicketConversation` already centralizes both standard and external comment ordering behind the same `reverseOrder` state.
|
|
- (2026-03-09) The repo already has server-backed user preference infrastructure, but it is unnecessary for this scope and would over-expand the change.
|
|
- (2026-03-09) The shared Vitest setup does not expose a DOM-style `localStorage`, so these tests need an explicit test-local storage mock.
|
|
|
|
## Commands / Runbooks
|
|
|
|
- (2026-03-09) `npx vitest run packages/tickets/src/components/ticket/TicketConversation.commentOrderPreference.test.tsx packages/tickets/src/components/ticket/ticketConversationOrderPreference.test.ts`
|
|
- (2026-03-09) `cd server && npx vitest run --config vitest.config.ts ../packages/tickets/src/components/ticket/ticketConversationOrderPreference.test.ts ../packages/tickets/src/components/ticket/TicketConversation.commentOrderPreference.test.tsx`
|
|
|
|
## Links / References
|
|
|
|
- `packages/tickets/src/components/ticket/TicketConversation.tsx`
|
|
- `packages/user-composition/src/hooks/useUserPreferencesBatch.ts`
|
|
|
|
## Open Questions
|
|
|
|
- None.
|