Hermes 284313f908
Some checks are pending
Bidi Control Character Guard / bidi-control-guard (push) Waiting to run
Circular Dependency Check / Check for new circular dependencies (push) Waiting to run
Citus Migration Smoke / Combined migrations on single-node Citus (push) Waiting to run
E2E Fresh Install Tests / fresh-install-e2e (push) Waiting to run
ext-v2 guardrails / Run ext-v2 guard and ESLint (push) Waiting to run
Integration Tests / Check for relevant changes (push) Waiting to run
Integration Tests / ${{ (github.event_name == 'schedule' || github.event.inputs.suite == 'full') && 'Full integration suite' || 'Tier-1 integration subset' }} (push) Blocked by required conditions
Mobile checks / Mobile lint + typecheck (push) Waiting to run
Mobile checks / Mobile unit tests (push) Waiting to run
Mobile checks / Mobile dependency audit (report) (push) Waiting to run
Mobile checks / Mobile reproducibility checks (push) Waiting to run
Secrets guard (env backups) / Ensure no tracked env backup files (push) Waiting to run
Temporal Readiness / fast-readiness (push) Waiting to run
Temporal Readiness / docker-parity (push) Waiting to run
TypeScript Type Check / Nx affected typecheck (push) Waiting to run
Unit Tests / Skipped-test budget (push) Waiting to run
Unit Tests / Nx affected unit tests (push) Waiting to run
Unit Tests / Server unit coverage (informational) (push) Waiting to run
Validate Tenant Management Schema / Check for relevant changes (push) Waiting to run
Validate Tenant Management Schema / Validate Tenant Management Schema (push) Blocked by required conditions
EE Workflows Build Guard / ee-workflows-build-guard (push) Waiting to run
Initial import of AlgaPSA codebase from PSA server
Excluded: .git, node_modules, secrets/, compose.env, assemblyscript tgz

Source: /opt/alga-psa on psa.joliet.tech
2026-06-22 16:12:17 -05:00

2.2 KiB

Recurring Service-Period Due Selection

F242 defines the query contract that later invoice-generation passes will use to read due persisted service-period rows instead of re-deriving recurring schedules in memory.

This is the contract checkpoint, not the runtime cutover checkpoint:

  • F242 defines the selector inputs, eligibility filters, and sort order
  • F256 is still the later pass that makes live invoice generation consume persisted rows end to end

Query Inputs

The v1 persisted due-selection query is defined by:

  • tenant
  • executionWindow
  • cadenceOwner
  • exact [windowStart, windowEnd) invoice-window bounds
  • a resolved scheduleKeys[] scope
  • optional charge-family narrowing
  • eligible lifecycle states

The important boundary is scheduleKeys[]:

  • persisted service-period rows do not carry raw clientId
  • caller-side runtime selection must first resolve which recurring schedules belong to the current client / execution window
  • persisted due selection then reads only those schedule keys rather than scanning the whole tenant ledger

Eligibility Rules

shared/billingClients/recurringServicePeriodDueSelection.ts makes the first v1 eligibility rules explicit:

  • invoice-window matching is exact on [start, end) bounds
  • only generated, edited, and locked rows are eligible by default
  • skipped, billed, superseded, and archived rows are excluded
  • rows with existing invoiceLinkage are excluded because they are already billed history
  • cadence owner must match the execution window being evaluated

Ordering

Eligible rows are returned in deterministic order:

  1. servicePeriod.start
  2. servicePeriod.end
  3. sourceObligation.obligationId
  4. revision

That ordering keeps later invoice grouping deterministic before the runtime cutover replaces ad hoc derivation.

Deliberate Boundary

This checkpoint still does not:

  • switch BillingEngine.selectDueRecurringServicePeriodsForBillingWindow(...) to the persisted ledger
  • define parity comparison between derived schedules and persisted schedules
  • define historical backfill for already-billed recurring coverage

Those remain sequenced behind F243, F244, and F256.