284313f908
Some checks are pending
Bidi Control Character Guard / bidi-control-guard (push) Waiting to run
Circular Dependency Check / Check for new circular dependencies (push) Waiting to run
Citus Migration Smoke / Combined migrations on single-node Citus (push) Waiting to run
E2E Fresh Install Tests / fresh-install-e2e (push) Waiting to run
ext-v2 guardrails / Run ext-v2 guard and ESLint (push) Waiting to run
Integration Tests / Check for relevant changes (push) Waiting to run
Integration Tests / ${{ (github.event_name == 'schedule' || github.event.inputs.suite == 'full') && 'Full integration suite' || 'Tier-1 integration subset' }} (push) Blocked by required conditions
Mobile checks / Mobile lint + typecheck (push) Waiting to run
Mobile checks / Mobile unit tests (push) Waiting to run
Mobile checks / Mobile dependency audit (report) (push) Waiting to run
Mobile checks / Mobile reproducibility checks (push) Waiting to run
Secrets guard (env backups) / Ensure no tracked env backup files (push) Waiting to run
Temporal Readiness / fast-readiness (push) Waiting to run
Temporal Readiness / docker-parity (push) Waiting to run
TypeScript Type Check / Nx affected typecheck (push) Waiting to run
Unit Tests / Skipped-test budget (push) Waiting to run
Unit Tests / Nx affected unit tests (push) Waiting to run
Unit Tests / Server unit coverage (informational) (push) Waiting to run
Validate Tenant Management Schema / Check for relevant changes (push) Waiting to run
Validate Tenant Management Schema / Validate Tenant Management Schema (push) Blocked by required conditions
EE Workflows Build Guard / ee-workflows-build-guard (push) Waiting to run
Excluded: .git, node_modules, secrets/, compose.env, assemblyscript tgz Source: /opt/alga-psa on psa.joliet.tech
48 lines
1.8 KiB
Markdown
48 lines
1.8 KiB
Markdown
# Task Document Folder Selector Design
|
|
|
|
## Goal
|
|
|
|
Make the project task dialog document flow match the ticket details document flow when creating or uploading a document.
|
|
|
|
## Problem
|
|
|
|
`packages/projects/src/components/TaskDocumentsSimple.tsx` currently special-cases pending task mode (`!taskId`):
|
|
|
|
- `New` skips folder selection and creates the document at the root.
|
|
- `Upload` passes `folderPath: null`, which bypasses the shared upload folder chooser and uploads to the root.
|
|
|
|
This differs from the ticket details screen, which uses the shared documents flow and prompts for a destination folder before creating or uploading.
|
|
|
|
## Decision
|
|
|
|
Update the task dialog so pending task mode follows the same folder-selection flow as tickets:
|
|
|
|
- `New` always opens `FolderSelectorModal` before opening the document editor.
|
|
- `Upload` no longer forces root-folder upload in pending mode, allowing the shared upload component to prompt for a destination folder.
|
|
|
|
Link-existing behavior remains unchanged.
|
|
|
|
## Scope
|
|
|
|
Only change the project task document UI behavior in `TaskDocumentsSimple.tsx`.
|
|
|
|
Do not change:
|
|
|
|
- ticket documents behavior
|
|
- document association behavior on task save
|
|
- linked-document selection behavior
|
|
|
|
## Expected Result
|
|
|
|
- In task create mode, clicking `New` shows the folder selector first.
|
|
- In task create mode, clicking `Upload` shows the folder selector before upload starts.
|
|
- In task edit mode, behavior remains unchanged.
|
|
- Ticket details remains the reference behavior and is unaffected.
|
|
|
|
## Verification
|
|
|
|
- Open the task dialog in create mode and confirm `New` shows the folder picker.
|
|
- Open the task dialog in create mode and confirm `Upload` shows the folder picker.
|
|
- Open the task dialog in edit mode and confirm create/upload still work.
|
|
- Confirm ticket details document behavior is unchanged.
|